Specify context in all microcluster methods#105
Merged
Conversation
neoaggelos
requested review from
markylaing,
masnax,
roosterfish and
tomponline
as code owners
Signed-off-by: Angelos Kolaitis <angelos.kolaitis@canonical.com>
Signed-off-by: Angelos Kolaitis <angelos.kolaitis@canonical.com>
neoaggelos
force-pushed
the
feat/microcluster-app-context
branch
from
f55f80d to
d4fc493
Compare
masnax
previously approved these changes
Apr 15, 2024
roosterfish
reviewed
Apr 16, 2024
Contributor
roosterfish
left a comment
roosterfish
left a comment
There was a problem hiding this comment.
Thanks, just one remark on the Ready() function.
This was referenced Apr 16, 2024
Signed-off-by: Angelos Kolaitis <angelos.kolaitis@canonical.com>
Signed-off-by: Angelos Kolaitis <angelos.kolaitis@canonical.com>
Signed-off-by: Angelos Kolaitis <angelos.kolaitis@canonical.com>
neoaggelos
force-pushed
the
feat/microcluster-app-context
branch
from
a8f317d to
763315c
Compare
Contributor
Author
|
Force pushed because of missing signed-off-by in the new commits |
markylaing
reviewed
Apr 16, 2024
markylaing
previously requested changes
Apr 16, 2024
Contributor
markylaing
left a comment
markylaing
left a comment
There was a problem hiding this comment.
Hi @neoaggelos sorry to nitpick, we try to keep a linear git history to make cherry-picking easier when maintaining snap channels. Can you please amend the commit which changed the flag to a duration rather than adding a new one? Thanks.
Signed-off-by: Angelos Kolaitis <angelos.kolaitis@canonical.com>
neoaggelos
force-pushed
the
feat/microcluster-app-context
branch
from
c89b955 to
1c6c067
Compare
roosterfish
approved these changes
Apr 18, 2024
Contributor
roosterfish
left a comment
roosterfish
left a comment
There was a problem hiding this comment.
I understand the commit for changing the flag's type is gone and instead you went with the approach suggested by @markylaing.
masnax
dismissed
markylaing’s stale review
Dismissing as comments have been addressed.
masnax
approved these changes
Apr 18, 2024
Contributor
masnax
left a comment
masnax
left a comment
There was a problem hiding this comment.
Overall, this looks good to me so I'll be merging it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*microcluster.MicroClusterstruct(*MicroCluster).Start, not during creation(*MicroCluster)methods to accept a context and use that insteadmicroctlfor new API, usecmd.Context()instead ofcontext.Background()microdfor new API, usecmd.Context()instead ofcontext.Background()