Reserve core endpoints#231
Merged
Merged
Conversation
roosterfish
requested changes
Aug 12, 2024
Contributor
roosterfish
left a comment
roosterfish
left a comment
There was a problem hiding this comment.
Looks good thanks, only some smaller comments.
...for CoreAPI servers Fixes canonical#227 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
MggMuggins
force-pushed
the
reserve-core-endpoints
branch
from
188d71c to
b5a8dfb
Compare
Contributor
Author
|
It occurred to me that only checking the PathPrefix wouldn't catch resources where We also should probably require at least one endpoint in every resource. Happy to drop those commits if that's the wrong assumption. |
masnax
approved these changes
Aug 12, 2024
Contributor
masnax
left a comment
masnax
left a comment
There was a problem hiding this comment.
LGTM, thanks @MggMuggins!
roosterfish
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent CoreAPI extension servers from creating endpoints under
/core.Fixes #227