v2: Backport websocket client functions#239
Merged
Merged
Conversation
masnax
suggested changes
Aug 20, 2024
Contributor
masnax
left a comment
masnax
left a comment
There was a problem hiding this comment.
Can you please use git cherry-pick -x for the commits so we can use the commit message to track that they were backported?
This allows opening up mTLS connections to remotes for which the server certificate isn't yet known to the local instance of microcluster. This is useful during the pre-init phase or to reach potential remote microcluster members that haven't yet joined the cluster. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 2e0b2ba)
This allows reusing the URL merging techniques. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 5816e40)
This allows opening up a websocket connection to the microcluster API using either the local or remote client. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 31082c3)
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 8959957)
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 5719bea)
roosterfish
force-pushed
the
backport_websocket
branch
from
a3160b0 to
019e4ab
Compare
Contributor
Author
Ah yes, fixed. |
masnax
approved these changes
Aug 21, 2024
6 tasks
masnax
added a commit
to canonical/microcloud
that referenced
this pull request
Oct 8, 2024
This PR adds the explicit trust establishment to MicroCloud according to the spec in https://discourse.ubuntu.com/t/explicit-trust-establishment-mechanism-for-microcloud/44261. The PR adds the EFF wordlist with over 1300 lines so please consider this for the review. The license information is based on https://www.eff.org/copyright. It has the following dependencies which have to be met before it can be marked as ready: * LXD: canonical/lxd#13969 * MicroCluster: canonical/microcluster#239 In addition we are currently waiting on MicroCeph to merge the `v2` of MicroCluster which is also are requirement for this PR. Open TODO's: - [x] Align test suite to work with updated questions - [x] Release minor version of MicroCluster to allow pulling the new websocket client functions in (we will track the commit for now) - [x] Update this PR's `go.mod` file if the dependencies are met - [x] Check for additional unit testing capabilities for the changes in this PR - [x] Remove the TODO (regarding https://github.com/canonical/microcluster/blob/a4c5273899ac294750d63089f81f78fd1894df67/internal/rest/resources/api_1.0.go#L21-L25) after importing MicroCluster `v2` - [x] Update the docs (e.g. preseed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #237 into
v2.