Rest: Return validation errors from the database handlers#241
Merged
Conversation
Make sure to run the database request handler before actually hijacking the connection. This ensures errors occurred during request validation can still be forwarded to the caller. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
If the request path is database related and the response is not of type EmptySyncResponse return the error to the caller as the connection wasn't yet hijacked. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Contributor
|
Should this get backported to |
Contributor
Author
Yes I'll create a PR. |
masnax
added a commit
that referenced
this pull request
Aug 27, 2024
Backports the commits from #241.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240
This PR ensures that any request validation for the database handlers happens before hijacking the connection so that errors can be returned to the caller.