Start cleanup/reset after request is done#310
Merged
Conversation
When resetting a cluster member the shutdown procedures should be invoked only after the connection that was used to trigger the reset has been closed (context cancelled). The database might be already stopped but the request's context isn't yet cancelled. Furthermore the state directory should be cleaned after all the listeners are closed (including inotify) to prevent any errors trying to read the state directory. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
masnax
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this whilst reasoning about the effect of this change.
When resetting a cluster member the shutdown procedures should be invoked only after the connection that was used to trigger the reset has been closed (context cancelled). The database might be already stopped but the request's context isn't yet cancelled.
Furthermore the state directory should be cleaned after all the listeners are closed (including inotify) to prevent any errors trying to read the state directory.