Skip to content

doc: update example package developer docs#352

Merged
roosterfish merged 1 commit into
canonical:v3from
minaelee:update-example-package-docs
Mar 26, 2025
Merged

doc: update example package developer docs#352
roosterfish merged 1 commit into
canonical:v3from
minaelee:update-example-package-docs

Conversation

@minaelee
Copy link
Copy Markdown

Full update of the instructions for using the example package.

Comment thread example/README.md Outdated
@minaelee minaelee force-pushed the update-example-package-docs branch from 972f579 to 0a17b53 Compare March 18, 2025 16:13
Copy link
Copy Markdown
Contributor

@roosterfish roosterfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only two small comments.

Comment thread example/README.md Outdated
Comment thread example/README.md Outdated
@minaelee minaelee force-pushed the update-example-package-docs branch from 0a17b53 to f8dc23a Compare March 19, 2025 23:45
@minaelee minaelee force-pushed the update-example-package-docs branch 4 times, most recently from 37d0b82 to bb99051 Compare March 20, 2025 17:57
roosterfish added a commit that referenced this pull request Mar 21, 2025
Completes all planned updates in
https://warthogs.atlassian.net/browse/LXD-2645 except backporting to v2
branch, which is the final step after this and
#352 are merged.
@minaelee minaelee force-pushed the update-example-package-docs branch 4 times, most recently from fd90050 to e62d2e0 Compare March 24, 2025 23:24
@minaelee minaelee requested a review from roosterfish March 24, 2025 23:26
@minaelee minaelee force-pushed the update-example-package-docs branch 2 times, most recently from fca6373 to 1bb568a Compare March 24, 2025 23:34
@minaelee
Copy link
Copy Markdown
Author

minaelee commented Mar 24, 2025

Tests / Code failing at make check-static. Unclear why; passes locally for both make check-static and make -C example check-static.

@minaelee minaelee force-pushed the update-example-package-docs branch from 1bb568a to 0538d90 Compare March 24, 2025 23:40
@roosterfish
Copy link
Copy Markdown
Contributor

Tests / Code failing at make check-static. Unclear why; passes locally for both make check-static and make -C example check-static.

Should be fixed with #364

@roosterfish
Copy link
Copy Markdown
Contributor

Can be rebased now.

Signed-off-by: Minae Lee <minae.lee@canonical.com>
@minaelee minaelee force-pushed the update-example-package-docs branch from 0538d90 to 3648aae Compare March 25, 2025 20:18
@minaelee
Copy link
Copy Markdown
Author

Can be rebased now.

Thanks, done!

@roosterfish roosterfish merged commit 0ee23ca into canonical:v3 Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants