Add minimal CI tests#84
Merged
Merged
Conversation
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Contributor
|
Its asking for lxd-generate because the makefile defaults to updating the schema, there's no build directive. You want the makefile in the example package, or |
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
requested review from
markylaing,
masnax,
roosterfish and
tomponline
as code owners
Member
Author
|
@masnax OK, thanks I've added the corresponding |
masnax
approved these changes
Feb 2, 2024
Contributor
masnax
left a comment
masnax
left a comment
There was a problem hiding this comment.
LGTM, though did we always have those github actions errors about package comments? I don't believe any of our projects have strictly required package comments.
Member
Author
|
AFAIK, revive isn't used much elsewhere. |
masnax
pushed a commit
to masnax/microcluster
that referenced
this pull request
Dec 10, 2024
Add minimal CI tests (cherry picked from commit 96d6a37)
masnax
pushed a commit
to masnax/microcluster
that referenced
this pull request
Dec 10, 2024
Add minimal CI tests (cherry picked from commit 96d6a37) Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
masnax
pushed a commit
to masnax/microcluster
that referenced
this pull request
Dec 10, 2024
Add minimal CI tests (cherry picked from commit 96d6a37) Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
masnax
pushed a commit
to masnax/microcluster
that referenced
this pull request
Dec 11, 2024
Add minimal CI tests (cherry picked from commit 96d6a37) Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@masnax I made the needed changes to please golangci-lint but revive was too much so I made the
check-staticwarn instead of hard failing for now.I looked at building it but it wants
lxd-generateand I couldn't quickly find where to pull it from. Something for a future PR :)