Fix golangci lint#98
Merged
Merged
Conversation
MggMuggins
requested review from
markylaing,
masnax,
roosterfish and
tomponline
as code owners
tomponline
approved these changes
Apr 3, 2024
io/ioutil was deprecated in go 1.16 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
io/ioutil was deprecated in go 1.16 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
rand.Seed was deprecated in go 1.20 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
MggMuggins
force-pushed
the
fix-golangci-lint
branch
from
1cb827b to
66ee86f
Compare
masnax
added a commit
to masnax/microcluster
that referenced
this pull request
Dec 10, 2024
Fix golangci lint (cherry picked from commit e4c5384)
masnax
added a commit
to masnax/microcluster
that referenced
this pull request
Dec 10, 2024
Fix golangci lint (cherry picked from commit e4c5384) Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
masnax
added a commit
to masnax/microcluster
that referenced
this pull request
Dec 10, 2024
Fix golangci lint (cherry picked from commit e4c5384) Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
masnax
added a commit
to masnax/microcluster
that referenced
this pull request
Dec 11, 2024
Fix golangci lint (cherry picked from commit e4c5384) Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed these while trying to run the tests... before I discovered that there are none. Didn't want to waste the work.
Fixes golangci-lint
SA1019EDIT: This should probably wait to be merged until after #99, as the deprecation occurred at in go 1.20.