Fix XWayland menu positioning by initializing spec from cached geometry

[Copilot]

Closes #???

Related: #???, https://..., ...

What's new?

XWayland menus (e.g., CLion's project menu) were centering on their parent window instead of anchoring to the opening widget. Root cause: during surface creation, spec.top_left wasn't initialized from cached.geometry, causing prep_surface_spec to skip the aux_rect conversion logic that positions child windows relative to their parent.

Fix: Initialize spec.top_left from cached.geometry.top_left at surface creation (line 725), matching the existing pattern for width/height initialization.

// May be overridden by anything in the pending spec
spec.top_left = cached.geometry.top_left;  // <- Added
spec.width = cached.geometry.size.width;
spec.height = cached.geometry.size.height;

With position set, prep_surface_spec now:

1. Detects parent relationship via effective_parent
2. Converts absolute position to parent-relative coordinates
3. Populates aux_rect + placement hints
4. Window manager positions correctly instead of falling back to centering

How to test

1. Run miral-app --enable-x11 true
2. Launch CLion under XWayland
3. Open the projects menu
4. Verify menu anchors to the button, not center of window

Checklist

• Tests added and pass
• Adequate documentation added
• (optional) Added Screenshots or videos

Original prompt

---

This section details on the original issue you should resolve

<issue_title>The menu on CLion when running under XWayland is positioned in the center of the window instead of being anchored to the widget to wihich it is attached</issue_title>
<issue_description>### Version

v2.23.0

Environment

All of them

What happened? What did you expect to happen?

When running CLion under XWayland, the projects menu is positioned in the center of the CLion widget when opened instead of being anchored to the widget that opened the menu.

Reproduction steps

1. Run miral-app
2. Run CLion under Xwayland
3. Open the projects menu
4. See that the projects menu opens in the center of the screen

Expected: The project menu opens attached to the button that opened it.

Relevant log output

```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

• Fixes The menu on CLion when running under XWayland is positioned in the center of the window instead of being anchored to the widget to wihich it is attached #4511

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[github-actions]

TICS Quality Gate

✔️ Passed

mir

Coding Standards: ✔️ Passed

✔️ Condition “No new Coding Standard Violations for level 1, 2, 3 with respect to Previous analysis” passed.

See the results in the TICS Viewer

The following files have been checked for this project

• src/server/frontend_xwayland/xwayland_surface.cpp

TICS / TICS / Run TICS analysis

[mattkae]

Yup!

[AlanGriffiths]

Works for menus. (not for tips when hovering over button)