Use PROJECT_VERSION instead of the old MIR_VERSION variables #4544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkae
force-pushed
the
bugfix/versioning
branch
from
287bcc1 to
86a51a1
Compare
Saviq
requested changes
Dec 14, 2025
mattkae
force-pushed
the
bugfix/versioning
branch
from
86a51a1 to
a6b11fb
Compare
mattkae
force-pushed
the
bugfix/versioning
branch
from
a6b11fb to
044dda5
Compare
Contributor
Author
Fixed! |
mattkae
changed the title
Saviq
approved these changes
Dec 14, 2025
Contributor
Saviq
left a comment
Saviq
left a comment
There was a problem hiding this comment.
Of course 🤦, sorry.
2.25.1 incoming.
TICS Quality Gate✔️ PassedNo changed files applicable for TICS analysis quality gating. TICS / TICS / Run TICS analysis |
Saviq
added a commit
that referenced
this pull request
Dec 15, 2025
## What's new? - Mir's version strings are broken, so I am unable to inspect the version in both CMake and code in Miracle - Mir expects to replace @VARIABLE_NAME@ in spaces, so we should ensure that that can still happen Caused by: e79ad71 ## Checklist - [x] Tests added and pass - [x] Adequate documentation added - [x] (optional) Added Screenshots or videos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
Caused by: e79ad71
Checklist