Add the ability to set the alpha of a Window and retrieve it via WindowInfo#4704
Add the ability to set the alpha of a Window and retrieve it via WindowInfo#4704AlanGriffiths merged 7 commits intomainfrom
Conversation
tarek-y-ismail
left a comment
tarek-y-ismail
left a comment
There was a problem hiding this comment.
Other than the nits I pointed out, I don't have an issue with this addition. Though, I recall @AlanGriffiths not being 100% convinced? Maybe wait for a review from him as well.
| /// | ||
| /// \returns the alpha | ||
| /// \remark Since MirAL 5.6 | ||
| auto alpha() -> mir::optional_value<float>&; |
There was a problem hiding this comment.
I get using mir::optional_value for consistency. But shouldn't we start using std::optional for new things at this point?
There was a problem hiding this comment.
I figured it would be better to keep it for consistency at this point. I would hate to use an API that mixes the two personally.
| mir::input::CursorObserverMultiplexer::register_interest*; | ||
| mir::input::CursorObserverMultiplexer::register_early_observer*; | ||
| mir::input::CursorObserverMultiplexer::cursor_moved_to*; | ||
| mir::input::CursorObserverMultiplexer::image_set_to*; | ||
| mir::input::CursorObserverMultiplexer::operator*; | ||
| mir::input::CursorObserverMultiplexer::pointer_unusable*; | ||
| mir::input::CursorObserverMultiplexer::pointer_usable*; |
There was a problem hiding this comment.
I'm tempted to keep it since I just ran the tool :) And this does put it in alphabetical order. Saves future people from fighting the tool IMO
| non-virtual?thunk?to?mir::input::CursorObserverMultiplexer::image_set_to*; | ||
| non-virtual?thunk?to?mir::input::CursorObserverMultiplexer::pointer_unusable*; |
There was a problem hiding this comment.
Same as above, its a minor enough reorder imo
That's a long way down the "manual testing" leg! |
Apart from the nits you've raised, I don't have concerns. I remember Saviq pointing out that the existing feature being exposed here might not "do the right thing" when compositing popups and subsurfaces, but that's orthogonal to propagating the surface alpha channel through miral. |
TICS Quality Gate✔️ Passedmir
|
3 participants
What's new?
miral::WindowSpecification::alphamiral::WindowInfo::alphamir::scene::Surface::alphamir::scene::BasicSurface::set_alphaHow to test
FloatingWindowManagerto set an alpha of 0.5 on all new surfaces inplace_new_windowmiral-shellChecklist