Cleanup of the device module in evdev-rs#4722
Conversation
tarek-y-ismail
left a comment
There was a problem hiding this comment.
Some comments. I'm still dipping my toes so I might be missing some context.
tarek-y-ismail
left a comment
There was a problem hiding this comment.
Some final small nits you're free to resolve or ignore.
One thing I'm wondering though: Maybe this code belongs in its own crate/module? Basically, I don't see a need to prefix everything with Libinput, but I understand that this may be a limitation of having to interact with C++.
Yeah I don't want it to step on the C++ code. We'll see how the naming shapes out as I refactor more stuff |
TICS Quality Gate✔️ Passedmir
|
What's new?
device.rs. We don't need theRssuffix since all of this is namespaceddevice.rsHow to test
Everything still works 🎉
Checklist