Skip to content

Cleanup of the device module in evdev-rs#4722

Merged
mattkae merged 5 commits intomainfrom
evdev-rs-device-cleanup
Mar 3, 2026
Merged

Cleanup of the device module in evdev-rs#4722
mattkae merged 5 commits intomainfrom
evdev-rs-device-cleanup

Conversation

@mattkae
Copy link
Copy Markdown
Contributor

@mattkae mattkae commented Feb 24, 2026

What's new?

  • Fixed the naming conventions in device.rs. We don't need the Rs suffix since all of this is namespaced
  • Fixed a bunch of the indentation in device.rs
  • No functionality was changed!

How to test

Everything still works 🎉

Checklist

  • Tests added and pass
  • Adequate documentation added
  • (optional) Added Screenshots or videos

@mattkae mattkae requested a review from a team as a code owner February 24, 2026 19:01
Copy link
Copy Markdown
Contributor

@tarek-y-ismail tarek-y-ismail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. I'm still dipping my toes so I might be missing some context.

Comment thread src/platforms/evdev-rs/src/device.rs Outdated
Comment thread src/platforms/evdev-rs/src/device.rs Outdated
Comment thread src/platforms/evdev-rs/src/device.rs Outdated
Comment thread src/platforms/evdev-rs/src/device.rs
Comment thread src/platforms/evdev-rs/src/device.rs
Comment thread src/platforms/evdev-rs/src/device.rs
Comment thread src/platforms/evdev-rs/src/device.rs Outdated
Comment thread src/platforms/evdev-rs/src/device.rs Outdated
Comment thread src/platforms/evdev-rs/src/device.rs Outdated
Comment thread src/platforms/evdev-rs/src/device.rs
Copy link
Copy Markdown
Contributor

@tarek-y-ismail tarek-y-ismail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final small nits you're free to resolve or ignore.

One thing I'm wondering though: Maybe this code belongs in its own crate/module? Basically, I don't see a need to prefix everything with Libinput, but I understand that this may be a limitation of having to interact with C++.

Comment thread src/platforms/evdev-rs/src/device.rs Outdated
Comment thread src/platforms/evdev-rs/src/device.rs Outdated
Comment thread src/platforms/evdev-rs/src/device.rs
Comment thread src/platforms/evdev-rs/src/device.rs Outdated
@mattkae
Copy link
Copy Markdown
Contributor Author

mattkae commented Mar 3, 2026

Some final small nits you're free to resolve or ignore.

One thing I'm wondering though: Maybe this code belongs in its own crate/module? Basically, I don't see a need to prefix everything with Libinput, but I understand that this may be a limitation of having to interact with C++.

Yeah I don't want it to step on the C++ code. We'll see how the naming shapes out as I refactor more stuff

@mattkae mattkae enabled auto-merge March 3, 2026 13:22
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

TICS Quality Gate

✔️ Passed

mir

Coding Standards: ✔️ Passed

✔️ Condition “No new Coding Standard Violations for level 1, 2, 3 with respect to Previous analysis” passed.

See the results in the TICS Viewer

The following files have been checked for this project
  • src/platforms/evdev-rs/platform.cpp
  • src/platforms/evdev-rs/src/device.rs
  • src/platforms/evdev-rs/src/event_processing.rs
  • src/platforms/evdev-rs/src/lib.rs
  • src/platforms/evdev-rs/src/platform.rs

TICS / TICS / Run TICS analysis

@mattkae mattkae added this pull request to the merge queue Mar 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2026
@mattkae mattkae merged commit ab8fcc5 into main Mar 3, 2026
32 checks passed
@mattkae mattkae deleted the evdev-rs-device-cleanup branch March 3, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants