Skip to content

Comments

[ci] Trigger docs checks on merge_group too#3995

Merged
ricab merged 2 commits intomainfrom
check-docs-merge-group
Apr 22, 2025
Merged

[ci] Trigger docs checks on merge_group too#3995
ricab merged 2 commits intomainfrom
check-docs-merge-group

Conversation

@ricab
Copy link
Collaborator

@ricab ricab commented Mar 21, 2025

If there are incompatibilities between separate changes to docs, we want to detect that before merging.

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.27%. Comparing base (bd106dc) to head (ca6a692).
Report is 3643 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3995      +/-   ##
==========================================
- Coverage   89.44%   89.27%   -0.18%     
==========================================
  Files         260      259       -1     
  Lines       14999    14653     -346     
==========================================
- Hits        13416    13081     -335     
+ Misses       1583     1572      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xmkg
xmkg previously approved these changes Mar 21, 2025
@ricab
Copy link
Collaborator Author

ricab commented Mar 21, 2025

Meh
image

Anchors are not supported in workflow files ATTOW.
@ricab
Copy link
Collaborator Author

ricab commented Mar 21, 2025

FWIW actions/runner#1182

@xmkg
Copy link
Member

xmkg commented Mar 21, 2025

Meh image

YAML without anchors? What a shame. GitLab supports it, and it's a pretty handy thing.

Base automatically changed from skip-docs-checks-on-unrelated to main April 4, 2025 16:34
@ricab ricab dismissed xmkg’s stale review April 4, 2025 16:34

The base branch was changed.

@ricab ricab requested a review from levkropp April 14, 2025 14:48
Copy link
Contributor

@levkropp levkropp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, everything valid and as I understand it, this change should test itself as we add it to the merge queue

@ricab ricab requested a review from xmkg April 14, 2025 15:53
@xmkg xmkg added this pull request to the merge queue Apr 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 15, 2025
@xmkg xmkg added this pull request to the merge queue Apr 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 15, 2025
@ricab
Copy link
Collaborator Author

ricab commented Apr 15, 2025

Ugh? But it's all green...

@ricab ricab added this pull request to the merge queue Apr 15, 2025
@ricab ricab removed this pull request from the merge queue due to the queue being cleared Apr 15, 2025
@ricab ricab added this pull request to the merge queue Apr 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2025
@ricab ricab added this pull request to the merge queue Apr 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2025
@ricab ricab added this pull request to the merge queue Apr 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2025
@ricab ricab added this pull request to the merge queue Apr 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 17, 2025
@xmkg xmkg added this pull request to the merge queue Apr 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 18, 2025
@xmkg xmkg added this pull request to the merge queue Apr 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 18, 2025
@ricab ricab added this pull request to the merge queue Apr 21, 2025
Merged via the queue into main with commit 28222c6 Apr 22, 2025
16 checks passed
@ricab ricab deleted the check-docs-merge-group branch April 22, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants