Move openssl from binary installation to vcpkg #4023
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it is same as the standard build recipe, the purpose it to convert the dynamic linkage to static. As a result, we can avoid the windows openssl_applink.c problem.
georgeliao
force-pushed
the
move_openssl_to_vcpkg
branch
from
afcff52 to
ebda7f8
Compare
georgeliao
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4023 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 260 260
Lines 14738 14738
=======================================
Hits 13167 13167
Misses 1571 1571 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
This PR adds the ability to build on the latest macOS runners while still targeting an older version of macOS. The `CMAKE_OSX_DEPLOYMENT_TARGET` is propagated to vcpkg so that all dependencies are also built for the correct version of macOS. Because OpenSSL was originally fetched via brew installation, its binary would inherently target the version of macOS that it was being installed on. To remedy this, OpenSSL is now fetched from vcpkg. `windows-macos.yml` is subsequently pruned to no longer spawn unneeded macOS runners. The deployment target can be queried from a Multipass binary with the command `otool -l multipassd | grep -A 3 LC_BUILD_VERSION`. Updated licence information in the installer with the appropriate licence as found in the [openssl repository](https://github.com/openssl/openssl). Also, updated the licence information for semver as its source recently changed in #4461. Verified on a macOS 14 virtual machine. Nested virtualization is only supported on M3 and newer, so you will need to remove the CPU checks in `preinstall-multipassd.sh` and `CPack.distribution.dist.in`. Closes #4023 Closes canonical/multipass-private#739 --- MULTI-1920 MULTI-2272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
https://warthogs.atlassian.net/browse/MULTI-1920
Things are not finished
close #3889