-
Notifications
You must be signed in to change notification settings - Fork 757
[cpp headers] replace header guards with #pragma once #4090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cpp headers] replace header guards with #pragma once #4090
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4090 +/- ##
=======================================
Coverage 89.31% 89.31%
=======================================
Files 259 259
Lines 15715 15715
=======================================
Hits 14036 14036
Misses 1679 1679 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2781021 to
5a39556
Compare
5a39556 to
09d4e07
Compare
Done! |
|
Hey @xmkg, I am afraid this will need another go 💦 |
09d4e07 to
c989f79
Compare
No worries. I anticipated friction between the line-length branch and this one. Rebased to main, let's see if everything's still fine. |
c989f79 to
db46a51
Compare
db46a51 to
210c0ff
Compare
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
210c0ff to
eb05c4c
Compare
Sploder12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Neat to see this fixes some cases of bad header guards and missing copyrights too. But, you missed MULTIPASS_BLUEPRINTS_TEST_LAMBDAS_H ;)
Nah, that doesn't count... That's a source guard -- protecting against double inclusion of a source file. This PR is header guards only... Just joking 😛 Probably somebody copied this from a header and forgot to remove the guard. I'll remove it :) Good catch! |
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
|
BTW, I intentionally left the Flutter GUI header guards in place since some of them are generated code, and the rest is copied from the example app. |
Done! |
I completely missed that was from a |
ricab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, thanks for this!
…ards-with-pragma-once [cpp headers] replace header guards with #pragma once
|
I like this pr |
This PR replaces all instances of header guards with much simpler and widely supported
#pragma once.MULTI-1995