[vm-image-vault] Check for empty json before parse#4726
Merged
Conversation
boost::json::parse throws an exception if the input is empty so guard against that. Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
jimporter
approved these changes
Mar 11, 2026
Contributor
jimporter
left a comment
jimporter
left a comment
There was a problem hiding this comment.
Looks good to me! I think this is the obvious way to handle empty files, while still being noisy about invalid JSON.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4726 +/- ##
=======================================
Coverage 87.67% 87.67%
=======================================
Files 256 256
Lines 14113 14113
=======================================
Hits 12372 12372
Misses 1741 1741 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
deepakshirkem
pushed a commit
to deepakshirkem/multipass
that referenced
this pull request
Apr 26, 2026
boost::json::parse throws an exception if the input is empty so guard against that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boost::json::parse throws an exception if the input is empty so guard against that.