[platform-win] Add null check to pOldDACL#4735
Merged
Merged
Conversation
new_ACL function assumes that pOldDACL ptr would be non-empty after a successful `GetNamedSecurityInfo` call but that premise does not exists Excerpt from `GetNamedSecurityInfo` docs: > A pointer to a variable that receives a pointer to the DACL in the > returned security descriptor or NULL if the security descriptor has > no DACL. The returned pointer is valid only if you set the DACL_SECURITY_INFORMATION > flag. Also, this parameter can be NULL if you do not need the DACL. NULL DACL is a valid return value which means the queried security info has no DACL info (i.e., no access restrictions). The patch adds a null check to fix that. Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4735 +/- ##
=======================================
Coverage 87.65% 87.65%
=======================================
Files 258 258
Lines 14124 14124
=======================================
Hits 12379 12379
Misses 1745 1745 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tobe2098
approved these changes
Mar 27, 2026
Contributor
tobe2098
left a comment
tobe2098
left a comment
There was a problem hiding this comment.
LGTM, great catch Mustafa!
tobe2098
added a commit
that referenced
this pull request
Mar 30, 2026
The new_ACL function assumes that pOldDACL ptr would be non-empty after a successful `GetNamedSecurityInfo` call, but that premise does not exist Excerpt from `GetNamedSecurityInfo` docs: > A pointer to a variable that receives a pointer to the DACL in the > returned security descriptor or NULL if the security descriptor has > no DACL. The returned pointer is valid only if you set the DACL_SECURITY_INFORMATION > flag. Also, this parameter can be NULL if you do not need the DACL. NULL DACL is a valid return value, indicating that the queried security info has no DACL (i.e., no access restrictions). The patch adds a null check to fix that.
deepakshirkem
pushed a commit
to deepakshirkem/multipass
that referenced
this pull request
Apr 26, 2026
The new_ACL function assumes that pOldDACL ptr would be non-empty after a successful `GetNamedSecurityInfo` call, but that premise does not exist Excerpt from `GetNamedSecurityInfo` docs: > A pointer to a variable that receives a pointer to the DACL in the > returned security descriptor or NULL if the security descriptor has > no DACL. The returned pointer is valid only if you set the DACL_SECURITY_INFORMATION > flag. Also, this parameter can be NULL if you do not need the DACL. NULL DACL is a valid return value, indicating that the queried security info has no DACL (i.e., no access restrictions). The patch adds a null check to fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new_ACL function assumes that pOldDACL ptr would be non-empty after a successful
GetNamedSecurityInfocall, but that premise does not existExcerpt from
GetNamedSecurityInfodocs:NULL DACL is a valid return value, indicating that the queried security info has no DACL (i.e., no access restrictions).
The patch adds a null check to fix that.
MULTI-2519