Skip to content

[utils] Remove QT from generate_scrypt_hash_for#4768

Merged
xmkg merged 1 commit into
mainfrom
enhancement/remove-qt-from-scrypthash
Apr 7, 2026
Merged

[utils] Remove QT from generate_scrypt_hash_for#4768
xmkg merged 1 commit into
mainfrom
enhancement/remove-qt-from-scrypthash

Conversation

@xmkg
Copy link
Copy Markdown
Member

@xmkg xmkg commented Mar 27, 2026

Description

  • What does this PR do?
    Replaces QT types in the generate_scrypt_hash_for function.
  • Why is this change needed?
    std-ification efforts.

MULTI-2517

Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.66%. Comparing base (c6b3834) to head (b70ab0b).
⚠️ Report is 90 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4768   +/-   ##
=======================================
  Coverage   87.66%   87.66%           
=======================================
  Files         257      257           
  Lines       14127    14127           
=======================================
  Hits        12383    12383           
  Misses       1744     1744           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xmkg xmkg marked this pull request as ready for review March 27, 2026 15:51
@xmkg xmkg requested review from a team and tobe2098 and removed request for a team March 27, 2026 15:51
Copy link
Copy Markdown
Contributor

@tobe2098 tobe2098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job Mustafa!

@xmkg xmkg added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit d9888ee Apr 7, 2026
50 checks passed
@xmkg xmkg deleted the enhancement/remove-qt-from-scrypthash branch April 7, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants