[vm-image-vault] Normalize image path before replace#4813
Merged
Conversation
The replace_all call assumes the path is single forward slashes where Windows makes no such guarantees. Call generic_string() to grab a posix like normalized path so it's always forward slashes. Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
xmkg
changed the title
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4813 +/- ##
==========================================
+ Coverage 87.54% 87.54% +0.01%
==========================================
Files 258 258
Lines 14155 14157 +2
==========================================
+ Hits 12391 12393 +2
Misses 1764 1764 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update the instance_image_records map after verifying all invariants. Also add a test with invalid instance dir. Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
jimporter
requested changes
Apr 14, 2026
Contributor
jimporter
left a comment
jimporter
left a comment
There was a problem hiding this comment.
Good catch! The difference between .string() and .generic_string() is definitely something to be careful about with the standard path type. One comment below; I don't feel super strongly about it, but using boost::replace_all_copy seems like it lets us simplify this code a bit.
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The replace_all call assumes the path is single forward slashes, where Windows makes no such guarantees. Call generic_string() to grab a POSIX-like normalized path so it's always forward slashes.
MULTI-2563