Skip to content

fix: escape role_name on creation #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dpe
Choose a base branch
from
+2 −2
Open

fix: escape role_name on creation #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b935bb8
escape role name
paulomach Nov 27, 2025
4970760
Merge branch 'dpe' of github.com:canonical/mysql-router-operators int…
paulomach Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/common/mysql_shell/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,8 @@ def _create_application_database(self, *, database: str) -> None:
statements = [
f"CREATE ROLE `{role_name}`",
f"CREATE DATABASE `{database}`",
f"GRANT SELECT, INSERT, DELETE, UPDATE, EXECUTE ON `{database}`.* TO {role_name}",
f"GRANT ALTER, ALTER ROUTINE, CREATE, CREATE ROUTINE, CREATE VIEW, DROP, INDEX, LOCK TABLES, REFERENCES, TRIGGER ON `{database}`.* TO {role_name}",
f"GRANT SELECT, INSERT, DELETE, UPDATE, EXECUTE ON `{database}`.* TO `{role_name}`",
f"GRANT ALTER, ALTER ROUTINE, CREATE, CREATE ROUTINE, CREATE VIEW, DROP, INDEX, LOCK TABLES, REFERENCES, TRIGGER ON `{database}`.* TO `{role_name}`",
]

mysql_roles = self._get_mysql_roles("charmed_%")
Expand Down
Loading