networkd: rename GatewayOnlink= to GatewayOnLink=#273
Merged
Conversation
As of systemd v242 the "GatewayOnlink" spelling was deprecated and replaced by "GatewayOnLink", while still being available in compat mode. We've waited long enough and can switch to the proper spelling now. systemd/systemd@9cb8c55
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 61 61
Lines 10864 10864
=======================================
Hits 10764 10764
Misses 100 100
Continue to review full report at Codecov.
|
Contributor
|
Well, would have merged but "branch out of date" :) |
Contributor
Author
|
Used my admin powers to merge it without rebase. |
netdever
added a commit
to netdever/netplan
that referenced
this pull request
Apr 27, 2022
* ABI compatibility checker (canonical#269) * abigail: check-in 0.104 ABI XML serialization generated on Focal via: abidw libnetplan.so.0.0 --headers-dir include/ > abi-compat/focal_0.104.xml * abi-compat: use abigail to check ABI compatibility via GA * [WIP] src:types: move netplan_net_definition into a separate file This is to allow ABI compatibilty checks of NetplanNetDefinition using the 'abidiff' tool. * WIP: keep the ABI-specific structs self-contained Also, only move them in include/ for the ABI check, so that they don't get shipped as public headers. * GA CI: update comments * abi-compat: update XML according to latest state * GA: upgrade to abigail-tools 2.0 Using PPA version from https://launchpad.net/~slyon/+archive/ubuntu/ci-netplan * src: cleanup types.h ABI include Co-authored-by: Simon Chopin <simon.chopin@canonical.com> * networkd: rename GatewayOnlink= to GatewayOnLink= (canonical#273) As of systemd v242 the "GatewayOnlink" spelling was deprecated and replaced by "GatewayOnLink", while still being available in compat mode. We've waited long enough and can switch to the proper spelling now. systemd/systemd@9cb8c55 * cli:sriov: fix test coverage for quirk_devices newer coverage tools seem to be more picky, make them happy * Makefile: clean src/_features.h.gch file * Adding VRF and VXLAN support for systemd-networkd. LP: #1764716, #1773522 * Add vxlan/vrf changes to new abi.h file Co-authored-by: Lukas Märdian <slyon@ubuntu.com> Co-authored-by: Simon Chopin <simon.chopin@canonical.com> Co-authored-by: Anthony Timmins <atimmins@datto.com>
netdever
added a commit
to netdever/netplan
that referenced
this pull request
Apr 27, 2022
* ABI compatibility checker (canonical#269) * abigail: check-in 0.104 ABI XML serialization generated on Focal via: abidw libnetplan.so.0.0 --headers-dir include/ > abi-compat/focal_0.104.xml * abi-compat: use abigail to check ABI compatibility via GA * [WIP] src:types: move netplan_net_definition into a separate file This is to allow ABI compatibilty checks of NetplanNetDefinition using the 'abidiff' tool. * WIP: keep the ABI-specific structs self-contained Also, only move them in include/ for the ABI check, so that they don't get shipped as public headers. * GA CI: update comments * abi-compat: update XML according to latest state * GA: upgrade to abigail-tools 2.0 Using PPA version from https://launchpad.net/~slyon/+archive/ubuntu/ci-netplan * src: cleanup types.h ABI include Co-authored-by: Simon Chopin <simon.chopin@canonical.com> * networkd: rename GatewayOnlink= to GatewayOnLink= (canonical#273) As of systemd v242 the "GatewayOnlink" spelling was deprecated and replaced by "GatewayOnLink", while still being available in compat mode. We've waited long enough and can switch to the proper spelling now. systemd/systemd@9cb8c55 * cli:sriov: fix test coverage for quirk_devices newer coverage tools seem to be more picky, make them happy * Makefile: clean src/_features.h.gch file Co-authored-by: Lukas Märdian <slyon@ubuntu.com> Co-authored-by: Simon Chopin <simon.chopin@canonical.com> Co-authored-by: Anthony Timmins <atimmins@datto.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As of systemd v242 the "GatewayOnlink" spelling was deprecated and replaced by
"GatewayOnLink", while still being available in compat mode.
We've waited long enough and can switch to the proper spelling now.
systemd/systemd@9cb8c55
Checklist
make checksuccessfully.make check-coverage).