Feature/subcommand key recovery#155
Open
frederic-hoerni wants to merge 5 commits into
Open
Conversation
Packages at the same revision as snapd: secboot go-tpm2 go-efilib snapd reference: 4f657056a2389195c2fa7228a1e0b494dd91c734
The error was:
root@ubuntu-boot-test:~# ./nullbootctl
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x5dd87f]
goroutine 1 [running]:
github.com/canonical/go-efilib.getVarsBackend({0x0, 0x0})
.../go/pkg/mod/github.com/canonical/go-efilib@v1.7.1-0.20260310185303-7166aa858b24/vars.go:99 +0x1f
github.com/canonical/go-efilib.ListVariables({0x0, 0x0})
.../go/pkg/mod/github.com/canonical/go-efilib@v1.7.1-0.20260310185303-7166aa858b24/vars.go:168 +0x25
github.com/canonical/nullboot/efibootmgr.RealEFIVariables.ListVariables(...)
.../nullboot/efibootmgr/efivars.go:34
github.com/canonical/nullboot/efibootmgr.VariablesSupported(...)
.../nullboot/efibootmgr/efivars.go:134
github.com/canonical/nullboot/efibootmgr.NewBootManagerForVariables({0x8e1a38?, 0xc000022210?})
.../nullboot/efibootmgr/bootmgr.go:91 +0xa9
main.main()
.../nullboot/cmd/nullbootctl/main.go:58 +0x4c5
Things missing so far: - unit testing of new functions - complete functional testing of nullboot (non regression on other functions)
Coverage Report for CI Build 26085281643Coverage decreased (-7.0%) to 63.776%Details
Uncovered Changes
Coverage Regressions4 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.