Skip to content

Drop support for building rockcraft from its repository#969

Merged
arturo-seijas merged 4 commits intomainfrom
drop-unused-rockcraft
Mar 10, 2026
Merged

Drop support for building rockcraft from its repository#969
arturo-seijas merged 4 commits intomainfrom
drop-unused-rockcraft

Conversation

@arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Mar 10, 2026 •
edited
Loading

Applicable spec:

Overview

Drop support for building rockcraft from its repository

Rationale

This is not in use and the motivation to support it no longer exists

Workflow Changes

Checklist

@arturo-seijas arturo-seijas requested a review from a team as a code owner March 10, 2026 15:45
@arturo-seijas arturo-seijas requested review from Thanhphan1147 and cbartz and removed request for a team March 10, 2026 15:45
@arturo-seijas arturo-seijas enabled auto-merge (squash) March 10, 2026 16:41
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Test results for commit f72669f

Test coverage for f72669f

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-03-10 17:43:38.146573+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Test results for commit f72669f

Test coverage for f72669f

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-03-10 17:43:41.339684+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Test results for commit f72669f

Test coverage for f72669f

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-03-10 17:44:44.175774+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Test results for commit f72669f

Test coverage for f72669f

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-03-10 17:43:38.146573+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Test results for commit f72669f

Test coverage for f72669f

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-03-10 17:43:41.339684+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Test results for commit f72669f

Test coverage for f72669f

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-03-10 17:44:44.175774+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Unused entries in .trivyignore

Image: ghcr.io/canonical/test-foo:73ebae26eaf71e0462669ed86b00b03f1351934e-_1.0_amd64

The following CVEs are in .trivyignore but not ignored by Trivy anymore:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Unused entries in .trivyignore

Image: ghcr.io/canonical/test:a8ba9319ad0fe10278b87cf705838818e280ccdd-_1.0_amd64

The following CVEs are in .trivyignore but not ignored by Trivy anymore:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Unused entries in .trivyignore

Image: ghcr.io/canonical/test-foo:73ebae26eaf71e0462669ed86b00b03f1351934e-_1.0_amd64

The following CVEs are in .trivyignore but not ignored by Trivy anymore:

@arturo-seijas arturo-seijas merged commit fec144e into main Mar 10, 2026
91 checks passed
@arturo-seijas arturo-seijas deleted the drop-unused-rockcraft branch March 10, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeeKay3 DeeKay3 DeeKay3 approved these changes

@srbouffard srbouffard srbouffard approved these changes

@cbartz cbartz Awaiting requested review from cbartz cbartz is a code owner automatically assigned from canonical/platform-engineering

@Thanhphan1147 Thanhphan1147 Awaiting requested review from Thanhphan1147 Thanhphan1147 is a code owner automatically assigned from canonical/platform-engineering

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arturo-seijas @DeeKay3 @srbouffard