docs: reduce the amount of detail in the open/close port methods#1006
Merged
benhoyt merged 5 commits intocanonical:mainfrom Sep 21, 2023
Merged
docs: reduce the amount of detail in the open/close port methods#1006benhoyt merged 5 commits intocanonical:mainfrom
benhoyt merged 5 commits intocanonical:mainfrom
Conversation
…o the Juju docs for more.
benhoyt
requested changes
Sep 21, 2023
Collaborator
benhoyt
left a comment
There was a problem hiding this comment.
Changes look fine, just a typo, and the docs build seems to be failing (confirms my dislike of ReST).
Co-authored-by: Ben Hoyt <benhoyt@gmail.com>
Co-authored-by: Ben Hoyt <benhoyt@gmail.com>
Collaborator
Author
Ah, my bad. I built the docs after doing |
benhoyt
approved these changes
Sep 21, 2023
jnsgruk
approved these changes
Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the
open_port()andclose_port()documentation:juju expose/juju unexposeis required (true for machine, not true for k8s sidecar)Fixes #918