test: add type hinting to test_helpers#1014
Merged
benhoyt merged 6 commits intocanonical:mainfrom Sep 26, 2023
Merged
Conversation
benhoyt
approved these changes
Sep 26, 2023
Collaborator
benhoyt
left a comment
benhoyt
left a comment
There was a problem hiding this comment.
Huh, yeah, some of these are definitely messy. Oh well, if it helps us get type checks turned on on our test directory, I think it's worth it.
| path = test_case.fake_script_path / name | ||
| with path.open('wt') as f: | ||
| path: pathlib.Path = test_case.fake_script_path / name # type: ignore | ||
| with path.open('wt') as f: # type: ignore |
Collaborator
There was a problem hiding this comment.
Ah, the joys of Python type checking! :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: ignores to work around not being able to state the type offake_script_path- I think there will be a few of these through other test modules as well, as hints are added there. I feel it would be cleaner to have the fake script functionality in a class rather than dynamically added to TestCase instances, but that is a much more substantial changePartially addresses #1007