chore: remove impossible test #1886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
requested review from
dwilding,
james-garner-canonical and
tonyandrewmeyer
Contributor
|
How about if we pack one of our example charms instead? |
Contributor
Author
|
By all means contribute that :P |
Contributor
|
It should be minimal work to swap in examples/httpbin-demo as a charm to pack. I'm happy to give it a go, if neither of you are already working/planning it |
Contributor
That sounds great, thanks. The workflow can probably be simplified by dropping the matrix, repo, and commit bits, and using |
Contributor
|
I've done a separate PR for swapping in the httpbin charm: #1895 |
Contributor
Author
|
#1895 got merged. this PR no longer makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Job: https://github.com/canonical/operator/actions/runs/16064127575
My suggestion from #1878 did not outsmart GitHub.