docs: for 2.x, fix site title and unstyled error pages#1945
Merged
dwilding merged 2 commits intocanonical:2.23-maintenancefrom Aug 1, 2025
Merged
docs: for 2.x, fix site title and unstyled error pages#1945dwilding merged 2 commits intocanonical:2.23-maintenancefrom
dwilding merged 2 commits intocanonical:2.23-maintenancefrom
Conversation
tonyandrewmeyer
approved these changes
Aug 1, 2025
benhoyt
approved these changes
Aug 1, 2025
Contributor
Author
|
Thanks for the reviews on this and the earlier PRs! This didn't seem to fix the error pages though. But I won't spend more time on this now. For the 3.x docs, I'm going to update to the latest starter pack, so I'll try to fix it for those docs. Then I'll backport the fix here if I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging #1942, I noticed a couple of issues with the 2.x docs: