Skip to content

Conversation

@dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Aug 19, 2025

Ignore Juju 4/beta timeouts on microk8s, as those seem to happen all the time.

@dimaqq
Copy link
Contributor Author

dimaqq commented Aug 19, 2025

matrix:
juju-channel: ['2.9/stable', '3/stable', '4/beta']
preset: ['machine', 'microk8s']
continue-on-error: ${{ matrix.juju-channel == '4/beta' && matrix.preset == 'microk8s' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I understanding this correctly? Since we use fail-fast: false, this doesn't change whether other jobs run, but it will show Juju4+microk8s as successful even if there are errors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it means that Juju4 + microk8s will still be visible as a failure (good!), but the workflow doesn't care whether that particular job was a success or failure -- the workflow can still get a green tick even if Juju4 + microk8s fails.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still get an email about the failure? I do think that's nice, so that each month we can check to see what's up - if it was just an expected issue with Juju 4 that's fine (although worth knowing for when we talk about 4 with charmers, although if there are indeed no more betas then perhaps this is all moot), but if it fails for some other reason we'd want to look into that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about the email.
Individual job is marked as failed.
The total job is marked as passed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, happy to approve and figure it out next month if needed :)

@dimaqq dimaqq merged commit 892c44a into canonical:main Aug 20, 2025
43 checks passed
@dimaqq dimaqq deleted the ci-continue-on-error branch August 20, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants