-
Notifications
You must be signed in to change notification settings - Fork 125
ci: ignore juju/4 timeouts #1998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Example: https://github.com/dimaqq/operator/actions/runs/17060535353 |
| matrix: | ||
| juju-channel: ['2.9/stable', '3/stable', '4/beta'] | ||
| preset: ['machine', 'microk8s'] | ||
| continue-on-error: ${{ matrix.juju-channel == '4/beta' && matrix.preset == 'microk8s' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I understanding this correctly? Since we use fail-fast: false, this doesn't change whether other jobs run, but it will show Juju4+microk8s as successful even if there are errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it means that Juju4 + microk8s will still be visible as a failure (good!), but the workflow doesn't care whether that particular job was a success or failure -- the workflow can still get a green tick even if Juju4 + microk8s fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still get an email about the failure? I do think that's nice, so that each month we can check to see what's up - if it was just an expected issue with Juju 4 that's fine (although worth knowing for when we talk about 4 with charmers, although if there are indeed no more betas then perhaps this is all moot), but if it fails for some other reason we'd want to look into that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about the email.
Individual job is marked as failed.
The total job is marked as passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, happy to approve and figure it out next month if needed :)
Ignore Juju 4/beta timeouts on microk8s, as those seem to happen all the time.