docs: make a Layer instead of a LayerDict in the httpbin charm
#2003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwilding
commented
Aug 22, 2025
examples/httpbin-demo/src/charm.py
Outdated
Comment on lines
143
to
142
| }, | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Ruff doesn't seem to care whether there's a comma here. Do we have a preference?
Collaborator
There was a problem hiding this comment.
I think this is because of the magic trailing comma behaviour. Basically, if you put a comma there it tells Ruff to format it to a separate line, and if there's no comma that it doesn't have to do that.
I'd add the trailing comma here, personally.
Contributor
Author
There was a problem hiding this comment.
Ah, thanks. I suppose there should be trailing commas in two places in that case. After 'services': {}, and after SERVICE_NAME: {},
tonyandrewmeyer
approved these changes
Aug 22, 2025
Collaborator
tonyandrewmeyer
left a comment
tonyandrewmeyer
left a comment
There was a problem hiding this comment.
LGTM! Thanks :)
dimaqq
approved these changes
Aug 22, 2025
benhoyt
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves canonical/charmcraft#1116 by changing the return type of the
_make_pebble_layerfunction in the httpbin demo charm. Our preference is to pass aroundLayerobjects rather thanLayerDictobjects. See the issue for detailed discussion.Drive-by: extract the environment variables from the layer definition, into a separate variable.