ci: nicer logging output in the release script using rich #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
approved these changes
Aug 28, 2025
Collaborator
benhoyt
left a comment
benhoyt
left a comment
There was a problem hiding this comment.
Fine with me. Can you show a before and after screenshot, just to refresh our memories of how it looked previously?
Contributor
Author
|
Here's an example of some logging from the |
Contributor
Author
|
Oh actually, the image I included in the PR body is not a good one, that was an intermediate version -- here's the actual output with |
Contributor
Author
|
I've amended the PR description with accurate before and after screenshots. |
dimaqq
approved these changes
Aug 28, 2025
james-garner-canonical
merged commit b261128
into
canonical:main
45 of 46 checks passed
Collaborator
tonyandrewmeyer
left a comment
tonyandrewmeyer
left a comment
There was a problem hiding this comment.
I didn't get much time to respond here, but approving retroactively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds coloured output for the logging in the
release.pyscript, usingrich.logging. This will be especially nice for the draft release, as it will more clearly separate the logging output visually from the release notes being printed. I tested this change by generating the post-release PR using this version of the script. I also tested that it runs cleanly for the draft release, bailing out with a keyboard interrupt on user input.Before:
After:
