docs: rename hook tools to hook commands #2114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwilding
approved these changes
Oct 16, 2025
Contributor
dwilding
left a comment
dwilding
left a comment
There was a problem hiding this comment.
Thanks for updating. I'd rather this was classified as "docs" - I think it deserves to be in the release notes, for visibility into the terminology change.
| if span: | ||
| span.set_attribute('call', 'subprocess.run') | ||
| # Some hook tool command line arguments may include sensitive data. | ||
| # The command-line arguments for some hook commands may include sensitive data. |
james-garner-canonical
changed the title
james-garner-canonical
approved these changes
Oct 16, 2025
Contributor
james-garner-canonical
left a comment
james-garner-canonical
left a comment
There was a problem hiding this comment.
The details look good to me. I see the Juju docs use the 'hook commands' terminology, so this makes sense.
Agree with David's comment to change the PR type from chore to docs -- in fact I went ahead and edited it so it's ready to merge.
tonyandrewmeyer
pushed a commit
to tonyandrewmeyer/operator
that referenced
this pull request
Oct 17, 2025
The Juju nomenclature has changed. Hook tools are hook commands now. Fixes canonical#2113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Juju nomenclature has changed.
Hook tools are hook commands now.
Fixes #2113