Skip to content

docs: secrets over CMR comment added#2271

Merged
dwilding merged 2 commits intocanonical:mainfrom
Abuelodelanada:fix/doc-how-to-secrets
Jan 18, 2026
Merged

docs: secrets over CMR comment added#2271
dwilding merged 2 commits intocanonical:mainfrom
Abuelodelanada:fix/doc-how-to-secrets

Conversation

@Abuelodelanada
Copy link
Copy Markdown
Contributor

This PR adds a comment in the Secrets How-To to reflect this comment.

@Abuelodelanada Abuelodelanada changed the title (DOC): secrets over CMR comment added (docs): secrets over CMR comment added Jan 14, 2026
@tonyandrewmeyer tonyandrewmeyer changed the title (docs): secrets over CMR comment added docs: secrets over CMR comment added Jan 14, 2026
Copy link
Copy Markdown
Contributor

@dwilding dwilding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Abuelodelanada, I have a couple of small suggestions, but this info is a good addition! If you and @dimaqq agree with my suggestions, I'd be very happy to push a commit & merge

Co-authored-by: Dave Wilding <tech@dpw.me>
@Abuelodelanada
Copy link
Copy Markdown
Contributor Author

Abuelodelanada commented Jan 15, 2026

@dwilding @dimaqq Thank you very much for your suggestions!

Copy link
Copy Markdown
Contributor

@dwilding dwilding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you again @Abuelodelanada! Merging now

@dwilding dwilding merged commit 1424fad into canonical:main Jan 18, 2026
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants