ci: remove outdated custom signature generation#2280
Merged
tonyandrewmeyer merged 2 commits intocanonical:mainfrom Jan 20, 2026
Merged
ci: remove outdated custom signature generation#2280tonyandrewmeyer merged 2 commits intocanonical:mainfrom
tonyandrewmeyer merged 2 commits intocanonical:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes outdated custom Sphinx documentation processing code that was previously needed to handle the _MaxPositionalArgs system, which provided keyword-only argument support for Scenario state classes in Python 3.8. Since the custom __new__ system has been removed (Python 3.8 is no longer supported), the custom Sphinx signature generation code is no longer needed.
Changes:
- Removed custom Sphinx signature generation monkeypatch and helper functions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dwilding
approved these changes
Jan 20, 2026
Contributor
dwilding
left a comment
dwilding
left a comment
There was a problem hiding this comment.
Good catch, thanks! I did a diff between your branch and main and the reference docs match identically 💯
dimaqq
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Ops 2.x, the Scenario state classes had a custom
__new__that provided keyword-only argument support for the data classes, since we had to support Python 3.8, which didn't have them.Sphinx wasn't able to figure out the signature to display using our custom code, so we also had a custom Sphinx processor to do that.
When we removed the custom
__new__system, we missed removing the customisation in the docs. This PR does that.Preview (should look unchanged from main).