chore: drop unused build dependency setuptools_scm#2318
Conversation
This PR drops Scenario's build dependency on [setuptools_scm](https://pypi.org/project/setuptools-scm/), which we don't need, as it's for versioning a package based on git tags. This resolves the current build issue, example identified by David [here](https://github.com/canonical/operator/actions/runs/21809969678/job/62920050703#step:5:22). The build issue can be reproduced locally on `main` with `uv build --all`. I've verified that the build succeeds with `setuptools_scm` removed. The root cause of why builds started failing isn't clear though.
|
One of the Observability Charm Test suites ( |
I think if you pull through the pinned versions from main that may fix this (it looks like an issue that was fixed upstream). |
That does fix Prometheus! But now Grafana is broken instead with |
Cherry-pick this commit. Sorry, it should probably have been merged into this branch in preparation of possible releases at the time. |
…nical#2239) The workflow removes `ops` as a dependency (so that it can add it back from main@HEAD), which also removes `ops[tracing]`. However, `grafana-k8s` now relies on that dependency, so that breaks the tests. This PR always adds `ops-tracing` as a dependency. `alertmanager-k8s` and `prometheus-k8s` don't currently need that, but they have other dependencies (like pedantic) that mean that packaging the charm should still work. We need a cleaner system than this, but I think canonical#1843 may end up solving this, and this will mean that the tests on main can pass again, so it seems a reasonable workaround. [Run in my fork](https://github.com/tonyandrewmeyer/operator/actions/runs/20250813274) - note that the failure is because of a different problem, and the grafana-k8s tests passing is the important piece.
|
Everything is green now. The release version bumps will be a separate PR. |
james-garner-canonical
merged commit 1f38c05
into
canonical:2.23-maintenance
3 participants
This PR follows
mainin dropping Scenario's build dependency on setuptools_scm, which we don't need, as it's for versioning a package based on git tags. This resolves build issues recently introduced by the package. The build issue can be reproduced locally withuv build --all.