fix: correct the Model.get_binding() return type#2329
Merged
tonyandrewmeyer merged 3 commits intocanonical:mainfrom Feb 17, 2026
Merged
fix: correct the Model.get_binding() return type#2329tonyandrewmeyer merged 3 commits intocanonical:mainfrom
Model.get_binding() return type#2329tonyandrewmeyer merged 3 commits intocanonical:mainfrom
Conversation
dimaqq
approved these changes
Feb 17, 2026
james-garner-canonical
approved these changes
Feb 17, 2026
Contributor
james-garner-canonical
left a comment
james-garner-canonical
left a comment
There was a problem hiding this comment.
Nice find, @Gu1nness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the
._bindingsattribute is a mapping, and we are usingget(), the implementation never returnsNone, it always creates a newBindingif there isn't one. The signature forget()is correct and does not includeNoneas a possible return type. This PR extends that to theget_binding()method.Issue reported by @Gu1nness on Matrix.