ci: run ruff check --fix in tox -e format#2369
Merged
james-garner-canonical merged 1 commit intocanonical:mainfrom Mar 11, 2026
Merged
Conversation
Contributor
|
I certainly end up running the second command every now and again, so this is welcome :) |
tonyandrewmeyer
approved these changes
Mar 10, 2026
Collaborator
tonyandrewmeyer
left a comment
tonyandrewmeyer
left a comment
There was a problem hiding this comment.
This seems reasonable to me - I generally find that the fixes that ruff check are the same fixes I would do manually.
dimaqq
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
tox -e formatto runruff check --preview --fixafter runningruff format --preview.Why?
tox -e lintwill complain about errors that are fixable withruff check --preview --fix, but we don't provide a way to fix them withtox. This is especially painful for import sorting errors. It's nice iftox -e formattakes care of the automated changes that satisfytox -e lint.This doesn't introduce new checks -- we already enforce
ruff check --previewonmainviatox -e lint. It just adds developer convenience.