Run some charm tests on Push/PR using Github Actions#611
Merged
jnsgruk merged 4 commits intocanonical:masterfrom Sep 27, 2021
jnsgruk:add-charm-tests
Merged
Run some charm tests on Push/PR using Github Actions#611jnsgruk merged 4 commits intocanonical:masterfrom jnsgruk:add-charm-tests
jnsgruk merged 4 commits intocanonical:masterfrom
jnsgruk:add-charm-tests
Conversation
…lo charms on push/PR
rbarry82
approved these changes
Sep 14, 2021
Vultaire
reviewed
Sep 15, 2021
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| python-version: [3.5, 3.6, 3.7, 3.8, 3.9] |
Contributor
There was a problem hiding this comment.
Note: if #607 is merged, 3.5 probably needs to be dropped here
Member
Author
|
Agreed, though I think this will merge prior to that PR. We'll just need to be careful to ensure we catch that! Thanks 😊 |
niemeyer
approved these changes
Sep 27, 2021
Collaborator
niemeyer
left a comment
niemeyer
left a comment
There was a problem hiding this comment.
As discussed live, looks good, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to the CI setup for this repo:
ci.yamltoframework-tests.yamlrequirements.txtfiles to use the latest commit in a PR/branch, then runs the tests usingtoxThe idea here is to catch any low hanging fruit/errors in changes to the framework or
Harness.This does imply a dependency on the upstream charm tests actually being correct, but that doesn't stop judgement being applied by the people merging PRs in this repo as to why the tests are failing. Once the Observability have their releasing more defined with CI, we can point at the branch that is associated with
latest/stablefor each charm, where there is a stronger expectation that all tests will pass. TheHello, *charms are much more static, and the tests are unlikely to change often.