-
Notifications
You must be signed in to change notification settings - Fork 27
[DPE-8473] Handle invalid database name (databases)
#1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (67.29%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1108 +/- ##
===========================================
+ Coverage 67.23% 67.29% +0.05%
===========================================
Files 19 19
Lines 3956 3951 -5
Branches 564 564
===========================================
- Hits 2660 2659 -1
+ Misses 1123 1119 -4
Partials 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lid database name and to handle storage ownership and permissions Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
9bc9be2 to
13c94d6
Compare
…se-name Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
…se-name Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
…se-name Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
databases)
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
…se-name Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Issue
With the new predefined roles implemented for PG 16, if a client app requests a database called databases while the PG charm tries to set up the roles for it, a failure will happen because one of the roles will conflict with the already existing charmed_databases_owner role (responsible for owning all the databases).
Solution
This PR is a follow-up from canonical/postgresql-single-kernel-library#18.
The data directory permissions were fixed, as it was done on canonical/postgresql-operator#1156. Some more fixes across this charm codebase might need to be done to make everything consistent.
Another thing that was done in this PR was to move the Pebble container that is retrieved multiple times in
src/charm.pyto a cached property. There are still some other places in other Python files that retrieve the Pebble container and need to be updated. This new cached property will also be useful when we start passing the container to the single kernel library objects.Checklist