-
Notifications
You must be signed in to change notification settings - Fork 27
[DPE-7584] Update single kernel library to fix tmpfs ownership and permission after reboot #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-7584] Update single kernel library to fix tmpfs ownership and permission after reboot #1156
Conversation
…at tmpfs storage works after reboot Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
…e-directory-permissions Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (64.51%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1156 +/- ##
========================================
Coverage 64.51% 64.51%
========================================
Files 17 17
Lines 4337 4337
Branches 671 671
========================================
Hits 2798 2798
Misses 1357 1357
Partials 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pyproject.toml
Outdated
charm-refresh = "^3.1.0.2" | ||
httpx = "^0.28.1" | ||
postgresql-charms-single-kernel = "^0.0.1" | ||
postgresql-charms-single-kernel = {url = "https://github.com/canonical/postgresql-single-kernel-library/archive/59d9092301cc57ed0e15d6152373176fba49536e.zip"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be changed to 16.0.1 after canonical/postgresql-single-kernel-library#11 is merged and published.
…e-directory-permissions Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why tests are so unstable (again?). 16/edge suposed to be more stable. Nope?
It's supposed. What's happening is the following: after a restore, the permissions of the storage directories are being set to a different value than the one that is set when the workload starts the database in a fresh cluster. I'm checking if there is a reason for that; otherwise, I'll fix those too. |
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
This reverts commit 7263ae4. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
…ermission when the instance is bootstrapped Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
The issue is described at canonical/postgresql-single-kernel-library#17 description. I fixed the issue in that PR (and imported the code of the commit on this PR just to ensure it really fixes the issue). I also fixed the directory permissions used in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, should you use proper lib version?
pyproject.toml
Outdated
charm-refresh = "^3.1.0.2" | ||
httpx = "^0.28.1" | ||
postgresql-charms-single-kernel = "^0.0.1" | ||
postgresql-charms-single-kernel = {url = "https://github.com/canonical/postgresql-single-kernel-library/archive/a8a9cdaedbc11365773a80de7aa3b6bef58941f4.zip"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16.0.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. Updated on fd7bd63.
…e-directory-permissions Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Issue
If temp storage is using tmpfs and the unit is rebooted, that storage is remounted with wrong permissions, leading to failures when a database user tries to create temporary objects in the database.
Solution
Update the single kernel library dependency to fix the issue.
Add an integration test for checking that the tmpfs storage works after a reboot.
Depends on canonical/postgresql-single-kernel-library#11.
Checklist