Skip to content

Conversation

@onkolahmet
Copy link

@onkolahmet onkolahmet commented Nov 10, 2025

Added PG-16 worker process and WAL compression configuration options.

  • 6 worker process settings (cpu-max-logical-replication-workers, cpu-max-parallel-apply-workers-per-subscription, cpu-max-parallel-maintenance-workers, cpu-max-parallel-workers, cpu-max-sync-workers-per-subscription, cpu-max-worker-processes)
  • 1 WAL compression setting (cpu-wal-compression)
    All options support "auto" values with defaults and include descriptions for PG-16 compatibility.

@github-actions github-actions bot added the Libraries: Out of sync The charm libs used are out-of-sync label Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 91.50943% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.46%. Comparing base (451a463) to head (7127f33).
⚠️ Report is 2 commits behind head on 16/edge.

Files with missing lines Patch % Lines
src/charm.py 90.62% 4 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           16/edge    #1284      +/-   ##
===========================================
+ Coverage    69.82%   70.46%   +0.63%     
===========================================
  Files           16       16              
  Lines         4149     4249     +100     
  Branches       658      684      +26     
===========================================
+ Hits          2897     2994      +97     
  Misses        1045     1045              
- Partials       207      210       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@onkolahmet onkolahmet added the enhancement New feature, UI change, or workload upgrade label Nov 10, 2025
@taurus-forever taurus-forever changed the title config expose for postgresql-16 VM [DPE-8860] config expose for postgresql-16 VM Nov 20, 2025
Merge origin/16/edge into expose_configs_pg16
@onkolahmet onkolahmet marked this pull request as ready for review November 21, 2025 09:50
@onkolahmet onkolahmet requested review from a team, dragomirp, marceloneppel and taurus-forever and removed request for a team November 21, 2025 09:51
@marceloneppel
Copy link
Member

@onkolahmet, please add a description to the PR. You should explain the issue and the solution. You can follow some examples from other PRs from the repo, like #1281, #1258, and #1191.

@github-actions github-actions bot added Libraries: OK The charm libs used are OK and in-sync and removed Libraries: Out of sync The charm libs used are out-of-sync labels Nov 24, 2025
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @onkolahmet!

Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Ahmet!

@onkolahmet onkolahmet merged commit 459e5b4 into 16/edge Dec 5, 2025
960 of 991 checks passed
@onkolahmet onkolahmet deleted the expose_configs_pg16 branch December 5, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, UI change, or workload upgrade Libraries: OK The charm libs used are OK and in-sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants