Skip to content

[DPE-9370] Handle retry error in bulk update#1427

Merged
dragomirp merged 2 commits into16/edgefrom
bulk-status-update-16
Feb 9, 2026
Merged

[DPE-9370] Handle retry error in bulk update#1427
dragomirp merged 2 commits into16/edgefrom
bulk-status-update-16

Conversation

@dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Feb 6, 2026

  • Raise exceptions on error codes for parallel get calls and config patching
  • Handle failure to patch config

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@github-actions github-actions bot added the Libraries: Out of sync The charm libs used are out-of-sync label Feb 6, 2026
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.53%. Comparing base (114f032) to head (3f530e7).
⚠️ Report is 2 commits behind head on 16/edge.

Files with missing lines Patch % Lines
src/charm.py 44.44% 4 Missing and 1 partial ⚠️
src/cluster.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           16/edge    #1427      +/-   ##
===========================================
- Coverage    70.62%   70.53%   -0.10%     
===========================================
  Files           15       15              
  Lines         4252     4259       +7     
  Branches       689      690       +1     
===========================================
+ Hits          3003     3004       +1     
- Misses        1041     1046       +5     
- Partials       208      209       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dragomirp dragomirp added the bug Something isn't working as expected label Feb 6, 2026
@dragomirp dragomirp marked this pull request as ready for review February 7, 2026 17:26
@dragomirp dragomirp requested review from a team, carlcsaposs-canonical, juju-charm-bot, marceloneppel and taurus-forever and removed request for a team February 7, 2026 17:27
marceloneppel
marceloneppel previously approved these changes Feb 9, 2026
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dragomirp dragomirp merged commit 827135f into 16/edge Feb 9, 2026
268 of 271 checks passed
@dragomirp dragomirp deleted the bulk-status-update-16 branch February 9, 2026 18:34
marceloneppel pushed a commit that referenced this pull request Mar 10, 2026
* Handle retry error in bulk update

* Move out the raise from the logging statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected Libraries: Out of sync The charm libs used are out-of-sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants