[DPE-7584] Fix permissions comparison #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The backups, smoke, and restore cluster tests started to fail with the following error at https://github.com/canonical/postgresql-operator/actions/runs/17796882879 because we incorrectly compare values in two different formats.
temp_location_stats.st_mode
returns16832
andPOSTGRESQL_STORAGE_PERMISSIONS
returns448
when the permissions of both are0o700
, which triggers a tablespace rename every time, even when the directory permissions are correct, leading to the above error.Solution
Convert the output from the
st_mode
attribute to the same format that we retrieve from thePOSTGRESQL_STORAGE_PERMISSIONS
constant.Also, I added the missing unit test (
test_set_up_database_owner_and_permissions_match_no_rename_or_fix
) to validate this conversion.Checklist