Conversation
blakerouse
force-pushed
the
snap-packaging
branch
2 times, most recently
from
a9ef201 to
4d611b4
Compare
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 67.13% 67.08% -0.06%
==========================================
Files 70 70
Lines 5715 5723 +8
Branches 985 987 +2
==========================================
+ Hits 3837 3839 +2
- Misses 1668 1674 +6
Partials 210 210
Continue to review full report at Codecov.
|
blakerouse
force-pushed
the
snap-packaging
branch
2 times, most recently
from
23a36b1 to
b91b42d
Compare
blakerouse
force-pushed
the
snap-packaging
branch
from
8c6a5f0 to
9c00eb8
Compare
albertodonato
left a comment
albertodonato
left a comment
There was a problem hiding this comment.
A few comments/questions
| if os.environ.get("SNAP_INSTANCE_NAME"): | ||
| return os.environ.get("SNAP_INSTANCE_NAME") | ||
| if os.environ.get("SNAP_NAME"): | ||
| return os.environ.get("SNAP_NAME") |
There was a problem hiding this comment.
you shouldn't need this, SNAP_INSTANCE_NAME is always there for the snap
There was a problem hiding this comment.
Okay will remove it, didn't know if that would always be the case, if you had a older snapd.
There was a problem hiding this comment.
I think that got introduced way before content interface :)
| interface: content | ||
| content: maas-cli | ||
| read: | ||
| - $SNAP/lib |
There was a problem hiding this comment.
can't we just expose the path of the library?
There was a problem hiding this comment.
We need all the dependencies not just the libmaas pieces, so I thought it best to expose the whole lib section. Only thing under there is lib/python3.6/site-packages anyway.
3 participants
Adds snap/snapcraft.yaml and improves the help menu to use the snap instance name. Add maas-cli content interface so "maas" snap can connect to this snap to get the latest CLI.