Skip to content

More Python 3.10 fixes#282

Merged
sparkiegeek merged 2 commits intocanonical:masterfrom
sparkiegeek:collections-abc-python310
Aug 16, 2022
Merged

More Python 3.10 fixes#282
sparkiegeek merged 2 commits intocanonical:masterfrom
sparkiegeek:collections-abc-python310

Conversation

@sparkiegeek
Copy link
Copy Markdown
Contributor

Follow-up to #271 to fix import errors on Python 3.10

Fixes #280

@troyanov troyanov self-requested a review August 16, 2022 10:03
Copy link
Copy Markdown
Member

@troyanov troyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #282 (6617dff) into master (fb06cab) will increase coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   69.01%   69.05%   +0.03%     
==========================================
  Files          72       72              
  Lines        5932     5933       +1     
  Branches     1310     1336      +26     
==========================================
+ Hits         4094     4097       +3     
+ Misses       1614     1606       -8     
- Partials      224      230       +6     
Impacted Files Coverage Δ
maas/client/flesh/tabular.py 47.34% <50.00%> (+0.23%) ⬆️
maas/client/flesh/__init__.py 39.84% <0.00%> (ø)
maas/client/flesh/machines.py 20.37% <0.00%> (ø)
maas/client/flesh/profiles.py 50.51% <0.00%> (ø)
maas/client/viscera/nodes.py 97.14% <0.00%> (+2.85%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sparkiegeek sparkiegeek merged commit a067368 into canonical:master Aug 16, 2022
@sparkiegeek sparkiegeek deleted the collections-abc-python310 branch August 16, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error listing anything: module 'collections' has no attribute 'Iterable'

3 participants