Skip to content

feat(CustomSelect): add selectedLabel#1260

Merged
kimanhou merged 1 commit intocanonical:mainfrom
kimanhou:multiselect-selected-label
Oct 6, 2025
Merged

feat(CustomSelect): add selectedLabel#1260
kimanhou merged 1 commit intocanonical:mainfrom
kimanhou:multiselect-selected-label

Conversation

@kimanhou
Copy link
Contributor

@kimanhou kimanhou commented Oct 2, 2025

Done

  • CustomSelect: add selectedLabel prop. When provided, it is displayed in toggle.

QA

Pinging @canonical/react-library-maintainers for a review.

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Steps for QA.

Percy steps

  • List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.

Signed-off-by: Kim Anh Nguyen <4783194+kimanhou@users.noreply.github.com>
@webteam-app
Copy link

Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA and Code LGTM, thanks for extending the component to allow customization.

Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for enabling the select label override

@kimanhou kimanhou merged commit d54a491 into canonical:main Oct 6, 2025
8 checks passed
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kimanhou kimanhou deleted the multiselect-selected-label branch October 27, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants