feat: add endpoint to get snap logs#40
Merged
st3v3nmw merged 1 commit intocanonical:mainfrom Mar 25, 2026
Merged
Conversation
aliihsancengiz
force-pushed
the
support-logs-endpoint
branch
from
ff679fc to
d4bd3dd
Compare
Contributor
Author
|
Would be cool if @Perfect5th and @st3v3nmw have a look. |
aliihsancengiz
force-pushed
the
support-logs-endpoint
branch
from
d4bd3dd to
b5cd500
Compare
Member
|
Hi @aliihsancengiz, I'll try review this today. |
st3v3nmw
reviewed
Mar 24, 2026
aliihsancengiz
force-pushed
the
support-logs-endpoint
branch
from
b5cd500 to
2c4fe5a
Compare
aliihsancengiz
changed the title
st3v3nmw
approved these changes
Mar 25, 2026
Member
st3v3nmw
left a comment
st3v3nmw
left a comment
There was a problem hiding this comment.
Tested this locally and it's working as expected.
One thing we can do next is parse the application/x-ndjson result into a list of objects, I'll look into this before the next release.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39