Fix instance recovery disable to purge all related SAAS apps#735
Merged
hemanthnakkina merged 2 commits intoJun 2, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Instance Recovery disable flow to purge all related cross-model SAAS applications (not just masakari), and adds a unit test to validate the new purge list composition.
Changes:
- Update
run_disable_plans()to pass the full application list fromset_application_names()intoRemoveSaasApplicationsStep. - Add a unit test asserting disable purges Consul + Masakari-related SAAS apps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
sunbeam-python/sunbeam/features/instance_recovery/feature.py |
Expands SAAS purge list during disable to include all apps returned by set_application_names(). |
sunbeam-python/tests/unit/sunbeam/features/test_instance_recovery_feature.py |
Adds test coverage to ensure disable purges Consul + Masakari SAAS apps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hemanthnakkina
requested changes
May 20, 2026
Collaborator
hemanthnakkina
left a comment
hemanthnakkina
left a comment
There was a problem hiding this comment.
LGTM, please fix the copilot review comments
Collaborator
|
@ahmad-can In case you missed, can you fix copilot review comments or reply to the comment |
ahmad-can
force-pushed
the
fix-instance-recovery-saas-termination-on-disable
branch
from
7b5a75a to
d42b423
Compare
hemanthnakkina
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.