docs: add explanation for the build and how-to for build passthroughs#504
Merged
medubelko merged 3 commits intocanonical:mainfrom Jan 28, 2026
Merged
Conversation
medubelko
requested review from
SecondSkoll,
akcano,
dwilding,
minaelee,
rkratky and
tang-mm
as code owners
medubelko
changed the title
medubelko
commented
Jan 22, 2026
tang-mm
reviewed
Jan 22, 2026
Contributor
tang-mm
left a comment
tang-mm
left a comment
There was a problem hiding this comment.
Nice write-up and thanks for documenting the solution! My main suggestion is to clearly state eligibility upfront (as much as we know) to prevent potential build failures in legacy or specialized environments
akcano
previously requested changes
Jan 22, 2026
dwilding
reviewed
Jan 23, 2026
dwilding
reviewed
Jan 23, 2026
a-velasco
approved these changes
Jan 23, 2026
dwilding
reviewed
Jan 26, 2026
Contributor
dwilding
left a comment
dwilding
left a comment
There was a problem hiding this comment.
Changes look great, thanks! On this reading, I spotted a potential issue related to pip version. I'm sorry, I missed this the first time I was looking at the Makefile.
dwilding
approved these changes
Jan 27, 2026
Contributor
dwilding
left a comment
dwilding
left a comment
There was a problem hiding this comment.
A couple of minor suggestions - but overall I really like the updated structure and explanations. Nice one!
Collaborator
Author
|
@dwilding @a-velasco @tang-mm @akcano Thanks so much for your reviews! You've helped make this a much better doc. I'm going to PR this against main, so some force-pushes are incoming. |
`VALEDIR` represents the package directory for Vale, yet it re-establishes the same path as `VENVDIR`. It makes more sense to compose it from `VENVDIR`. Furthermore, since `VENVDIR` is configurable by the calling environment, it stands to reason that `VALEDIR` should be, too.
medubelko
force-pushed
the
docpr-2420-docs-build-bridge
branch
from
f1a8f7f to
34a64cb
Compare
medubelko
dismissed
akcano’s stale review
All comments addressed, GitHub is being difficult.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the companion document to #494.
- [ ] Have you updatedCHANGELOG.mdwith relevant non-documentation file changes?