build(tools): add a Makefile that uses uv - #240
Merged
Merged
Conversation
dariuszd21
reviewed
Sep 3, 2024
lengau
force-pushed
the
build/makefile-uv
branch
from
September 4, 2024 16:27
44c40f9 to
c4b8542
Compare
Co-authored-by: Dariusz Duda <darekduda21@gmail.com>
dariuszd21
approved these changes
Sep 6, 2024
dariuszd21
left a comment
dariuszd21
left a comment
Contributor
There was a problem hiding this comment.
I'm not a fan of the duplicated dependencies (especially in a tool specific section), but besides that I think it looks pretty cool.
I like the idea of Make-driven approach, but I think if we go that way we should do it the same way as pydantic 2 migration - all tools at one time.
If any library or app will stay behind, we we'll still be left with the problem of inconsistency in our own repositories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox?