Skip to content

Change Mjolnir username#89

Merged
amandahla merged 1 commit into
mainfrom
isd-1191
Oct 27, 2023
Merged

Change Mjolnir username#89
amandahla merged 1 commit into
mainfrom
isd-1191

Conversation

@amandahla

Copy link
Copy Markdown
Contributor

Overview

As requested in issue #81 , this PR changes Mjolnir user to "moderator".

To take into consideration: the user created by previous versions ("mjolnir") should be manually deleted.

Rationale

Make username more approachable.

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

@amandahla amandahla requested a review from a team as a code owner October 27, 2023 14:39

@arturo-seijas arturo-seijas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

Test coverage for 25b378e

Name                            Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------------
src/actions/__init__.py             3      0      0      0   100%
src/actions/register_user.py       22      0      2      0   100%
src/actions/reset_instance.py      21      0      2      0   100%
src/charm.py                      175      8     32      4    94%   124-125, 177-178, 197-198, 239, 253
src/charm_state.py                 64      1     12      1    97%   141
src/charm_types.py                 11      0      0      0   100%
src/database_client.py             53      1     10      3    94%   35, 47->exit, 69->exit
src/database_observer.py           54      4      6      0    93%   70-72, 88
src/exceptions.py                   4      0      0      0   100%
src/mjolnir.py                     76      8     20      2    88%   60-64, 73, 93-96
src/observability.py                9      0      0      0   100%
src/pebble.py                      77     10      6      3    84%   90-91, 93, 95, 109-114
src/saml_observer.py               45      1      8      0    98%   64
src/synapse/__init__.py             3      0      0      0   100%
src/synapse/api.py                161      2     22      2    98%   207, 376
src/synapse/workload.py           200      6     30      5    95%   361-362, 378, 427->430, 476, 478, 483
src/user.py                        24      0      4      0   100%
---------------------------------------------------------------------------
TOTAL                            1002     41    154     20    95%

Static code analysis report

Run started:2023-10-27 14:47:58.657307

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 5054
  Total lines skipped (#nosec): 4
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@amandahla amandahla merged commit dca3d24 into main Oct 27, 2023
@amandahla amandahla deleted the isd-1191 branch October 27, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants